Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 7324054: Make version info get stored in the correct resource for chrome_frame_helper.exe and chrome_frame... (Closed)

Created:
9 years, 5 months ago by robertshield
Modified:
9 years, 5 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Make version info get stored in the correct resource for chrome_frame_helper.exe and chrome_frame_helper.dll. Switch to using '1' as the version resource name since that is less fragile against #include path mix ups, etc. BUG=65354 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92053

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome_frame/chrome_frame_helper_version.rc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_tab_version.rc View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertshield
9 years, 5 months ago (2011-07-11 15:53:46 UTC) #1
grt (UTC plus 2)
http://codereview.chromium.org/7324054/diff/1/chrome_frame/chrome_frame_helper_version.rc File chrome_frame/chrome_frame_helper_version.rc (right): http://codereview.chromium.org/7324054/diff/1/chrome_frame/chrome_frame_helper_version.rc#newcode12 chrome_frame/chrome_frame_helper_version.rc:12: 1 VERSIONINFO chrome_tab_version.rc still uses VS_VERSION_INFO. how about we ...
9 years, 5 months ago (2011-07-11 17:31:52 UTC) #2
robertshield
Switched to #including the right header in the CF .rc files. PTAL http://codereview.chromium.org/7324054/diff/1/chrome_frame/chrome_frame_helper_version.rc File chrome_frame/chrome_frame_helper_version.rc ...
9 years, 5 months ago (2011-07-11 17:55:14 UTC) #3
grt (UTC plus 2)
LGTM
9 years, 5 months ago (2011-07-11 18:07:57 UTC) #4
grt (UTC plus 2)
9 years, 5 months ago (2011-07-11 18:50:20 UTC) #5
LGTM++

Powered by Google App Engine
This is Rietveld 408576698