Sync Promo: Add "Setup Chrome Sync" menu item to the wrench menu

Sync Promo: Add "Setup Chrome Sync" menu item to the wrench menu

To better promote Sync we want to add a new "Setup Chrome Sync" menu item to the wrench menu. Clicking on the menu item shows the "sync sign in" dialog.

If the user is already signed into sync then clicking on the menu item shows the "configure sync" dialog.

BUG=None
TEST=Ran and verified that the menu item works.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92245

[Miranda Callahan, 2011-07-10 04:04:54]

LGTM with grd change.

http://codereview.chromium.org/7324038/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7324038/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:8360: Setup <ph
name="SHORT_PRODUCT_NAME">$1<ex>Chrome</ex></ph> Sync
Actually, "Setup" is a noun -- "Set Up" should be the two-word command form.

http://codereview.chromium.org/7324038/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:8365: Setup <ph
name="SHORT_PRODUCT_NAME">$1<ex>Chrome</ex></ph> sync
Same as above.

[sail, 2011-07-10 04:08:14]

http://codereview.chromium.org/7324038/diff/1/chrome/app/generated_resources.grd
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/7324038/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:8360: Setup <ph
name="SHORT_PRODUCT_NAME">$1<ex>Chrome</ex></ph> Sync
On 2011/07/10 04:04:55, Miranda Callahan wrote:
> Actually, "Setup" is a noun -- "Set Up" should be the two-word command form.

Done.

http://codereview.chromium.org/7324038/diff/1/chrome/app/generated_resources....
chrome/app/generated_resources.grd:8365: Setup <ph
name="SHORT_PRODUCT_NAME">$1<ex>Chrome</ex></ph> sync
On 2011/07/10 04:04:55, Miranda Callahan wrote:
> Same as above.

Done.

[commit-bot: I haz the power, 2011-07-12 11:30:52]

Can't process patch for file chrome/browser/ui/toolbar/wrench_menu_model.cc.
File's status is None, patchset upload is incomplete.

[commit-bot: I haz the power, 2011-07-12 21:54:27]

Change committed as 92245

[Nico, 2011-07-12 22:06:25]

Every CL that changes UI needs a bug that has UI leads approval. (You could've
probably used the multiprofile umbrella bug for this, but it needs to be clear
who ok'd it.)

[sail, 2011-07-12 22:16:10]

On 2011/07/12 22:06:25, Nico wrote:
> Every CL that changes UI needs a bug that has UI leads approval. (You could've
> probably used the multiprofile umbrella bug for this, but it needs to be clear
> who ok'd it.)

I filed bug http://crbug.com/89101 for this.

[sail, 2011-07-12 22:16:10]

On 2011/07/12 22:06:25, Nico wrote:
> Every CL that changes UI needs a bug that has UI leads approval. (You could've
> probably used the multiprofile umbrella bug for this, but it needs to be clear
> who ok'd it.)

I filed bug http://crbug.com/89101 for this.

[Nico, 2011-07-12 22:17:35]

On Tue, Jul 12, 2011 at 3:16 PM,  <sail@chromium.org> wrote:
> On 2011/07/12 22:06:25, Nico wrote:
>>
>> Every CL that changes UI needs a bug that has UI leads approval. (You
>> could've
>> probably used the multiprofile umbrella bug for this, but it needs to be
>> clear
>> who ok'd it.)
>
> I filed bug http://crbug.com/89101 for this.

Thanks!

>
> http://codereview.chromium.org/7324038/
>