Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/browser/ui/webui/options/advanced_options_handler.h

Issue 7324031: Revert 91861 - When the download folder does not exist, change the download folder to a user's "D... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/advanced_options_handler.h
===================================================================
--- chrome/browser/ui/webui/options/advanced_options_handler.h (revision 91868)
+++ chrome/browser/ui/webui/options/advanced_options_handler.h (working copy)
@@ -21,37 +21,6 @@
public SelectFileDialog::Listener,
public CloudPrintSetupHandlerDelegate {
public:
-
- class DownloadPathChecker
- : public base::RefCountedThreadSafe<DownloadPathChecker> {
- public:
- explicit DownloadPathChecker(AdvancedOptionsHandler* handler);
-
- // Check if the download folder still exists. If the download folder
- // does not exist, the download folder is changed to the user's
- // "Downloads" folder. This check runs in the background and may finish
- // asynchronously after this method returns.
- void CheckIfDownloadPathExists(const FilePath& path);
-
- private:
- friend class base::RefCountedThreadSafe<DownloadPathChecker>;
- ~DownloadPathChecker();
-
- // Called on the FILE thread to check the existence of the download folder.
- // If it does not exist, this method tells the user's "Downloads"
- // to OnDownloadPathChanged().
- void CheckIfDownloadPathExistsOnFileThread(const FilePath& path);
-
- // Called on the UI thread when the FILE thread finds that the download
- // folder does not exist. This method changes the download folder to
- // the user's "Downloads" folder and notifies this preference change
- // to observers.
- void OnDownloadPathChanged(const FilePath path);
-
- // The handler we will report back to.
- AdvancedOptionsHandler* handler_;
- };
-
AdvancedOptionsHandler();
virtual ~AdvancedOptionsHandler();
@@ -164,7 +133,7 @@
void SetupFontSizeLabel();
- // Setup the download folder based on user preferences.
+ // Setup the download path based on user preferences.
void SetupDownloadLocationPath();
// Setup the pref whether to prompt for download location every time.
@@ -179,8 +148,6 @@
// Setup the checked state for SSL related checkboxes.
void SetupSSLConfigSettings();
- scoped_refptr<DownloadPathChecker> download_path_checker_;
-
scoped_refptr<SelectFileDialog> select_folder_dialog_;
#if !defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/download/download_tab_helper.cc ('k') | chrome/browser/ui/webui/options/advanced_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698