Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7324031: Revert 91861 - When the download folder does not exist, change the download folder to a user's "D... (Closed)

Created:
9 years, 5 months ago by johnme-google
Modified:
9 years, 5 months ago
Reviewers:
haraken1
CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 91861 - When the download folder does not exist, change the download folder to a user's "Downloads" (or something depending on the platform) Description of reverted commit follows: - Set the download folder to Foo. You can download a PDF file to Foo without being asked anything (if you do not choose "Ask where to save each file before downloading"). Then delete Foo. Now, if you try to download the PDF file, then a file chooser dialog is displayed suggesting your "Downloads" folder. - Set the download folder to Foo. Save an HTML to Bar by right-clicking and choosing "Save as ..." on the tab. If you try to save the HTML, the file chooser dialog is displayed suggesting Bar. Then delete Bar. Now, if you try to save the HTML, the file chooser dialog is displayed suggesting Foo. Then delete Foo. If you try to save the HTML, the file chooser dialog is displayed suggesting your "Downloads" folder. - Set the download folder to Foo. Observe that Foo is displayed as the download location in the preferences page. Then delete Foo and reload the preferences page. Observe that your "Downloads" folder is displayed as the download location in the preferences page. If you are opening multiple preferences pages, then this change is automatically reflected to all the preferences pages. BUG=32552 TEST=SavePageBrowserTest.SavedFolder1,SavePageBrowserTest.SavedFolder2,SavePageBrowserTest.SavedFolder3,DownloadTest.DownloadedFolder,DownloadManagerTest.StartDownload,BaseFileTest.*,DownloadFileTest.RenameFileFinal Review URL: http://codereview.chromium.org/6973052 TBR=haraken@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -575 lines) Patch
M chrome/browser/download/base_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/base_file.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 28 chunks +50 lines, -106 lines 0 comments Download
M chrome/browser/download/download_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 4 chunks +21 lines, -13 lines 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +5 lines, -13 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 chunk +26 lines, -39 lines 0 comments Download
M chrome/browser/download/download_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/save_package.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/save_package.cc View 4 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 4 chunks +2 lines, -242 lines 0 comments Download
M chrome/browser/ui/download/download_tab_helper.h View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/ui/download/download_tab_helper.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.h View 3 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 4 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
johnme-google
9 years, 5 months ago (2011-07-08 17:26:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698