Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 7324029: Fix the bug of the hide key on Omnibox. (Closed)

Created:
9 years, 5 months ago by mazda
Modified:
9 years, 5 months ago
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

Fix the bug of the hide key on Omnibox. Fix a bug of hide key where the keyboard does now show up after the hide key is pressed while Omnibox has the focus and Omnibox is touched. I changed the way of retrieving the text input type to use InputMethod::GetTextInputType rather than TextInputClient::GetTextInputType because NULL is always set to touch_pressed_handler when omnibox is touched. I also added code to check the touch event type so that the notification is sent only when text element is touched. BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/ui/views/frame/browser_root_view.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M views/widget/root_view.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mazda
9 years, 5 months ago (2011-07-08 11:40:25 UTC) #1
bryeung
Peng is in the process of refactoring how the keyboard visibility is controlled. I've added ...
9 years, 5 months ago (2011-07-08 13:09:16 UTC) #2
Peng
On 2011/07/08 11:40:25, mazda wrote: LGTM
9 years, 5 months ago (2011-07-08 14:19:25 UTC) #3
bryeung
LGTM
9 years, 5 months ago (2011-07-08 14:22:02 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-08 15:25:04 UTC) #5
Change committed as 91854

Powered by Google App Engine
This is Rietveld 408576698