src/objects.cc - Issue 7324027: Fix: FunctionTemplate::SetPrototypeAttributes broke prototype object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 7324027: Fix: FunctionTemplate::SetPrototypeAttributes broke prototype object (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: different approach: new runtime function Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 26ab64552fc344fff7be569d3f43b365650c4d6f..d5742fc2e17f2d2c6aded65062458bbc3f7b0eb1 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -2435,6 +2435,8 @@ MaybeObject* JSObject::SetPropertyForResult(LookupResult* result,

// callback setter removed. The two lines looking up the LookupResult

// result are also added. If one of the functions is changed, the other

// should be.

+// Note that this method cannot be used to set the prototype of a function (it

+// will silently fail).

Rico 2011/07/25 13:05:42 I can't see where we actually silently fail in thi

Jakob Kummerow 2011/07/25 14:57:05 I've made the comment a bit more verbose.

MaybeObject* JSObject::SetLocalPropertyIgnoreAttributes(

String* name,

Object* value,

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/runtime.h » ('J')