Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: src/objects.cc

Issue 7324027: Fix: FunctionTemplate::SetPrototypeAttributes broke prototype object (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2417 matching lines...) Expand 10 before | Expand all | Expand 10 after
2428 return value; 2428 return value;
2429 } 2429 }
2430 2430
2431 2431
2432 // Set a real local property, even if it is READ_ONLY. If the property is not 2432 // Set a real local property, even if it is READ_ONLY. If the property is not
2433 // present, add it with attributes NONE. This code is an exact clone of 2433 // present, add it with attributes NONE. This code is an exact clone of
2434 // SetProperty, with the check for IsReadOnly and the check for a 2434 // SetProperty, with the check for IsReadOnly and the check for a
2435 // callback setter removed. The two lines looking up the LookupResult 2435 // callback setter removed. The two lines looking up the LookupResult
2436 // result are also added. If one of the functions is changed, the other 2436 // result are also added. If one of the functions is changed, the other
2437 // should be. 2437 // should be.
2438 // Note that this method cannot be used to set the prototype of a function
2439 // because ConvertDescriptorToField() which is called in "case CALLBACKS:"
2440 // doesn't handle function prototypes correctly.
2438 MaybeObject* JSObject::SetLocalPropertyIgnoreAttributes( 2441 MaybeObject* JSObject::SetLocalPropertyIgnoreAttributes(
2439 String* name, 2442 String* name,
2440 Object* value, 2443 Object* value,
2441 PropertyAttributes attributes) { 2444 PropertyAttributes attributes) {
2442 2445
2443 // Make sure that the top context does not change when doing callbacks or 2446 // Make sure that the top context does not change when doing callbacks or
2444 // interceptor calls. 2447 // interceptor calls.
2445 AssertNoContextChange ncc; 2448 AssertNoContextChange ncc;
2446 LookupResult result; 2449 LookupResult result;
2447 LocalLookup(name, &result); 2450 LocalLookup(name, &result);
(...skipping 9304 matching lines...) Expand 10 before | Expand all | Expand 10 after
11752 if (break_point_objects()->IsUndefined()) return 0; 11755 if (break_point_objects()->IsUndefined()) return 0;
11753 // Single beak point. 11756 // Single beak point.
11754 if (!break_point_objects()->IsFixedArray()) return 1; 11757 if (!break_point_objects()->IsFixedArray()) return 1;
11755 // Multiple break points. 11758 // Multiple break points.
11756 return FixedArray::cast(break_point_objects())->length(); 11759 return FixedArray::cast(break_point_objects())->length();
11757 } 11760 }
11758 #endif 11761 #endif
11759 11762
11760 11763
11761 } } // namespace v8::internal 11764 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698