Issue 7324022: For safety, cast XEvent to XkbEvent only when xevent->type holds a specific value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7324022: For safety, cast XEvent to XkbEvent only when xevent->type holds a specific value. (Closed)

Created:
9 years, 5 months ago by Yusuke Sato

Modified:
9 years, 5 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

For safety, cast XEvent to XkbEvent only when xevent->type holds a specific value. BUG=None TEST=manually checked that the indicator is shown/hidden correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91826

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/system_key_event_listener.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/system_key_event_listener.cc	View		3 chunks	+19 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm