Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Unified Diff: chrome/browser/chromeos/system/syslogs_provider.h

Issue 7324017: Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system/syslogs_provider.h
diff --git a/chrome/browser/chromeos/system_access.h b/chrome/browser/chromeos/system/syslogs_provider.h
similarity index 50%
rename from chrome/browser/chromeos/system_access.h
rename to chrome/browser/chromeos/system/syslogs_provider.h
index 857c43327805d494a900b1a79bd0e3c13675b11a..ecb92b6f9cfacc378df382677ce1f437ccf40a33 100644
--- a/chrome/browser/chromeos/system_access.h
+++ b/chrome/browser/chromeos/system/syslogs_provider.h
@@ -2,45 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_ACCESS_H_
-#define CHROME_BROWSER_CHROMEOS_SYSTEM_ACCESS_H_
+#ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_SYSLOGS_PROVIDER_H_
+#define CHROME_BROWSER_CHROMEOS_SYSTEM_SYSLOGS_PROVIDER_H_
#pragma once
#include <string>
#include "base/callback_old.h"
#include "content/browser/cancelable_request.h"
-#include "unicode/timezone.h"
class CancelableRequestConsumerBase;
namespace chromeos {
+namespace system {
typedef std::map<std::string, std::string> LogDictionaryType;
-// This interface provides access to Chrome OS system APIs such as the
-// timezone setting.
-class SystemAccess : public CancelableRequestProvider {
+// This interface provides access to Chrome OS syslogs.
+class SyslogsProvider : public CancelableRequestProvider {
public:
- class Observer {
- public:
- // Called when the timezone has changed. |timezone| is non-null.
- virtual void TimezoneChanged(const icu::TimeZone& timezone) = 0;
- };
-
- static SystemAccess* GetInstance();
-
- // Returns the current timezone as an icu::Timezone object.
- virtual const icu::TimeZone& GetTimezone() = 0;
-
- // Sets the current timezone. |timezone| must be non-null.
- virtual void SetTimezone(const icu::TimeZone& timezone) = 0;
-
- // Retrieve the named machine statistic (e.g. "hardware_class").
- // This does not update the statistcs. If the |name| is not set, |result|
- // preserves old value.
- virtual bool GetMachineStatistic(const std::string& name,
- std::string* result) = 0;
+ static SyslogsProvider* GetInstance();
// The callback type used with RequestSyslogs().
typedef Callback2<LogDictionaryType*,
@@ -65,14 +46,11 @@ class SystemAccess : public CancelableRequestProvider {
CancelableRequestConsumerBase* consumer,
ReadCompleteCallback* callback) = 0;
- // The observer is used to monitor timezone changes.
- virtual void AddObserver(Observer* observer) = 0;
- virtual void RemoveObserver(Observer* observer) = 0;
-
protected:
- virtual ~SystemAccess() {}
+ virtual ~SyslogsProvider() {}
};
+} // namespace system
} // namespace chromeos
-#endif // CHROME_BROWSER_CHROMEOS_SYSTEM_ACCESS_H_
+#endif // CHROME_BROWSER_CHROMEOS_SYSTEM_SYSLOGS_PROVIDER_H_
« no previous file with comments | « chrome/browser/chromeos/system/statistics_provider.cc ('k') | chrome/browser/chromeos/system/syslogs_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698