Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: chrome/browser/chromeos/customization_document.h

Issue 7324017: Split SystemAccess into TimezoneSettings, StatisticsProvider, and SyslogsProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/bug_report_util.cc ('k') | chrome/browser/chromeos/customization_document.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_DOCUMENT_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_DOCUMENT_H_
6 #define CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_DOCUMENT_H_ 6 #define CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_DOCUMENT_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 10 matching lines...) Expand all
21 class FilePath; 21 class FilePath;
22 class ListValue; 22 class ListValue;
23 class PrefService; 23 class PrefService;
24 24
25 namespace base { 25 namespace base {
26 class Time; 26 class Time;
27 } 27 }
28 28
29 namespace chromeos { 29 namespace chromeos {
30 30
31 class SystemAccess; 31 namespace system {
32 class StatisticsProvider;
33 } // system
32 34
33 // Base class for OEM customization document classes. 35 // Base class for OEM customization document classes.
34 class CustomizationDocument { 36 class CustomizationDocument {
35 public: 37 public:
36 virtual ~CustomizationDocument(); 38 virtual ~CustomizationDocument();
37 39
38 // Return true if the document was successfully fetched and parsed. 40 // Return true if the document was successfully fetched and parsed.
39 bool IsReady() const { return root_.get(); } 41 bool IsReady() const { return root_.get(); }
40 42
41 protected: 43 protected:
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 private: 75 private:
74 FRIEND_TEST(StartupCustomizationDocumentTest, Basic); 76 FRIEND_TEST(StartupCustomizationDocumentTest, Basic);
75 FRIEND_TEST(StartupCustomizationDocumentTest, VPD); 77 FRIEND_TEST(StartupCustomizationDocumentTest, VPD);
76 FRIEND_TEST(StartupCustomizationDocumentTest, BadManifest); 78 FRIEND_TEST(StartupCustomizationDocumentTest, BadManifest);
77 friend struct DefaultSingletonTraits<StartupCustomizationDocument>; 79 friend struct DefaultSingletonTraits<StartupCustomizationDocument>;
78 80
79 // C-tor for singleton construction. 81 // C-tor for singleton construction.
80 StartupCustomizationDocument(); 82 StartupCustomizationDocument();
81 83
82 // C-tor for test construction. 84 // C-tor for test construction.
83 StartupCustomizationDocument(SystemAccess* system_access, 85 StartupCustomizationDocument(system::StatisticsProvider* provider,
84 const std::string& manifest); 86 const std::string& manifest);
85 87
86 virtual ~StartupCustomizationDocument(); 88 virtual ~StartupCustomizationDocument();
87 89
88 void Init(SystemAccess* system_access); 90 void Init(system::StatisticsProvider* provider);
89 91
90 // If |attr| exists in machine stat, assign it to |value|. 92 // If |attr| exists in machine stat, assign it to |value|.
91 void InitFromMachineStatistic(const char* attr, std::string* value); 93 void InitFromMachineStatistic(const char* attr, std::string* value);
92 94
93 std::string initial_locale_; 95 std::string initial_locale_;
94 std::string initial_timezone_; 96 std::string initial_timezone_;
95 std::string keyboard_layout_; 97 std::string keyboard_layout_;
96 std::string registration_url_; 98 std::string registration_url_;
97 99
98 DISALLOW_COPY_AND_ASSIGN(StartupCustomizationDocument); 100 DISALLOW_COPY_AND_ASSIGN(StartupCustomizationDocument);
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 219
218 // Initial locale value. 220 // Initial locale value.
219 std::string initial_locale_; 221 std::string initial_locale_;
220 222
221 DISALLOW_COPY_AND_ASSIGN(ServicesCustomizationDocument); 223 DISALLOW_COPY_AND_ASSIGN(ServicesCustomizationDocument);
222 }; 224 };
223 225
224 } // namespace chromeos 226 } // namespace chromeos
225 227
226 #endif // CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_DOCUMENT_H_ 228 #endif // CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_DOCUMENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/bug_report_util.cc ('k') | chrome/browser/chromeos/customization_document.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698