chrome/browser/translate/translate_infobar_delegate.cc - Issue 7324001: Revert 89864 - Don't rely on user gestures for deciding when to dismiss infobars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_infobar_delegate.cc

Issue 7324001: Revert 89864 - Don't rely on user gestures for deciding when to dismiss infobars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/translate/translate_infobar_delegate.cc

===================================================================

--- chrome/browser/translate/translate_infobar_delegate.cc (revision 91739)

+++ chrome/browser/translate/translate_infobar_delegate.cc (working copy)

@@ -358,7 +358,7 @@

const content::LoadCommittedDetails& details) const {

// Note: we allow closing this infobar even if the main frame navigation

// was programmatic and not initiated by the user - crbug.com/70261 .

- if (!details.is_navigation_to_different_page() && !details.is_main_frame)

+ if (!details.is_user_initiated_main_frame_load() && !details.is_main_frame)

return false;

return InfoBarDelegate::ShouldExpireInternal(details);

« no previous file with comments | « chrome/browser/tab_contents/infobar_delegate.cc ('k') | chrome/browser/ui/browser_init.cc » ('j') | no next file with comments »