Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 7324001: Revert 89864 - Don't rely on user gestures for deciding when to dismiss infobars. (Closed)

Created:
9 years, 5 months ago by cmp
Modified:
9 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), brettw-cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 89864 - Don't rely on user gestures for deciding when to dismiss infobars. Previously, we looked at the user gesture state when deciding whether to dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can tell that this behavior is incorrect. Page-specific infobars, like translate, should close whenever the main frame navigates to a new page, regardless of whether that navigation was conducted from a user gesture. BUG=86417 Review URL: http://codereview.chromium.org/7205026 TBR=abarth@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/confirm_infobar_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/confirm_infobar_delegate.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/navigation_details.h View 2 chunks +14 lines, -5 lines 0 comments Download
M content/browser/tab_contents/navigation_details.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
cmp
9 years, 5 months ago (2011-07-07 19:13:48 UTC) #1
abarth-chromium
LGTM
9 years, 5 months ago (2011-07-07 19:25:18 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 20:42:35 UTC) #3
Change committed as 91744

Powered by Google App Engine
This is Rietveld 408576698