Issue 7322015: Add another test terminate condition in media perf test.

Issue 7322015: Add another test terminate condition in media perf test. (Closed)

Created:
9 years, 5 months ago by imasaki1

Modified:
9 years, 5 months ago

Reviewers:
dennis_jeffrey, Nirnimesh

CC:
chromium-reviews, cmp, hclam+watch_chromium.org, sjl, Nirnimesh, fischman+watch_chromium.org, John Grabowski, ajwong+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, anantha, dyu1, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), ddorwin+watch_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add another test terminate condition in media perf test. This is to catch the video playing error as early as possible (rather than waiting for timeout). This will prevent my script from occupying buildbot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91746

Patch Set 1 #

Patch Set 2 : Minor doc change. #

Total comments: 6

Patch Set 3 : Modification based on CR comments. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	chrome/test/functional/media/media_test_base.py	View	1 2	2 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

LGTM Just 3 minor comments to consider before submitting. Thank you! http://codereview.chromium.org/7322015/diff/3001/chrome/test/functional/media/media_test_base.py File chrome/test/functional/media/media_test_base.py (right): ...

9 years, 5 months ago (2011-07-07 19:45:19 UTC) #2

imasaki1

9 years, 5 months ago (2011-07-07 20:42:04 UTC) #3

Thanks. I am going to commit.

http://codereview.chromium.org/7322015/diff/3001/chrome/test/functional/media...
File chrome/test/functional/media/media_test_base.py (right):

http://codereview.chromium.org/7322015/diff/3001/chrome/test/functional/media...
chrome/test/functional/media/media_test_base.py:130: """Determine if the video
ended.
On 2011/07/07 19:45:21, dennis_jeffrey wrote:
> add something like this: '...or there was an error when playing.'

Done.

http://codereview.chromium.org/7322015/diff/3001/chrome/test/functional/media...
chrome/test/functional/media/media_test_base.py:137: True if the video has ended
or error out.
On 2011/07/07 19:45:21, dennis_jeffrey wrote:
> 'error out' --> 'an error occurred'

Done.

http://codereview.chromium.org/7322015/diff/3001/chrome/test/functional/media...
chrome/test/functional/media/media_test_base.py:140: 'ERROR' in
self.GetDOMValue('document.title'))
On 2011/07/07 19:45:21, dennis_jeffrey wrote:
> Recommend using parens like this:
> 
> return (self.GetDOMValue('document.title').strip() == 'END' or
>         'ERROR' in self.GetDOMValue('document.title'))

Done.

Expand Messages | Collapse Messages