Autofill button should get enabled and disabled according to the policy value.

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   // State variables.
   var syncEnabled = false;
@@ skipping 106 matching lines @@
       }
 
       if (PersonalOptions.disableAutofillManagement()) {
         $('autofill-settings').disabled = true;
 
         // Disable and turn off autofill.
         var autofillEnabled = $('autofill-enabled');
         autofillEnabled.disabled = true;
         autofillEnabled.checked = false;
         cr.dispatchSimpleEvent(autofillEnabled, 'change');
       }

[Joao da Silva, 2011/07/08 08:56:28]

I'd suggest handling updates to the pref here, similar to PasswordManagement
above. If the control is disabled because we're in Guest mode, don't react to
changes; otherwise listen for updates to the pref from here.

Preferences.getInstance().addEventListener() can be used to track the pref
value, without introducing new browser<->JS calls from the UIHandler.

[pastarmovj, 2011/07/08 09:33:30]

True good idea. This will save one unneeded IPC call too I guess.

On 2011/07/08 08:56:28, Joao da Silva wrote:

     },
 
     setSyncEnabled_: function(enabled) {
       this.syncEnabled = enabled;
     },
 
     setSyncSetupCompleted_: function(completed) {
       this.syncSetupCompleted = completed;
       $('customize-sync').hidden = !completed;
     },
@@ skipping 53 matching lines @@
     setGtkThemeButtonEnabled_: function(enabled) {
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i)) {
         $('themes-GTK-button').disabled = !enabled;
       }
     },
 
     setThemesResetButtonEnabled_: function(enabled) {
       $('themes-reset').disabled = !enabled;
     },
 
+    setAutoFillButtonEnabled_: function(enabled) {
+      $('autofill-settings').disabled = !enabled;

[Joao da Silva, 2011/07/08 08:56:28]

This can reenable the control when it was disabled because we are in Guest mode
(see PersonalOptions.disableAutofillManagement below on line 241).

[pastarmovj, 2011/07/08 09:33:30]

You are right. Good catch!

On 2011/07/08 08:56:28, Joao da Silva wrote:

+    },
+
     hideSyncSection_: function() {
       $('sync-section').hidden = true;
     },
 
     /**
      * Toggles the visibility of the data type checkboxes based on whether they
      * are enabled on not.
      * @param {Object} dict A mapping from data type to a boolean indicating
      *     whether it is enabled.
      * @private
@@ skipping 36 matching lines @@
     'setSyncStatusErrorVisible',
     'setSyncActionLinkEnabled',
     'setSyncActionLinkLabel',
     'setProfilesSectionVisible',
     'setNewProfileButtonEnabled',
     'setStartStopButtonVisible',
     'setStartStopButtonEnabled',
     'setStartStopButtonLabel',
     'setGtkThemeButtonEnabled',
     'setThemesResetButtonEnabled',
+    'setAutoFillButtonEnabled',
     'hideSyncSection',
     'setRegisteredDataTypes',
   ].forEach(function(name) {
     PersonalOptions[name] = function(value) {
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });