Enable clear cache/cookies support in developer tools

Enable clear cache/cookies support in developer tools


BUG=71687
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92352

[pfeldman, 2011-07-07 14:06:16]

http://codereview.chromium.org/7322008/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/7322008/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:642: // BrowsingDataRemover
takes care of deleting itself when done.
Place this comment under the ->Remove call.

http://codereview.chromium.org/7322008/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:644:
static_cast<BrowsingDataRemover::TimePeriod>(0),
What does this mean?

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_handler.cc (right):

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_handler.cc:86:
DevToolsManager::GetInstance()->ClearBrowserCache(render_view_host());
No need to go through DevToolsManager

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_manager.cc (right):

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_manager.cc:169: void
DevToolsManager::ClearBrowserCache(RenderViewHost* inspected_rvh) {
no need to change this.

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_manager.cc:173: void
DevToolsManager::ClearBrowserCookies(RenderViewHost* inspected_rvh) {
ditto

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
File content/browser/debugger/devtools_window.cc (right):

http://codereview.chromium.org/7322008/diff/1/content/browser/debugger/devtoo...
content/browser/debugger/devtools_window.cc:20: #include
"chrome/browser/ui/app_modal_dialogs/message_box_handler.h"
Could you try getting dialog creator from the browser or inspected_tab's browser
instead?

[vsevik, 2011-07-07 15:56:03]

PTAL

[pfeldman, 2011-07-11 11:46:40]

On 2011/07/07 15:56:03, vsevik wrote:
> PTAL

Looks good devtools-wise. Please refer to owners for the permission.

[vsevik, 2011-07-11 11:55:48]

Hi jam,

Could you please take a look on this?

[jam, 2011-07-12 01:13:00]

http://codereview.chromium.org/7322008/diff/4001/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.h (right):

http://codereview.chromium.org/7322008/diff/4001/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.h:105: virtual void
ClearBrowserCache(RenderViewHost*);
nit: the "Browser" is redundant

http://codereview.chromium.org/7322008/diff/4001/chrome/renderer/devtools_age...
File chrome/renderer/devtools_agent.h (right):

http://codereview.chromium.org/7322008/diff/4001/chrome/renderer/devtools_age...
chrome/renderer/devtools_agent.h:57: 
nit: why the blank line?

http://codereview.chromium.org/7322008/diff/4001/content/browser/content_brow...
File content/browser/content_browser_client.h (right):

http://codereview.chromium.org/7322008/diff/4001/content/browser/content_brow...
content/browser/content_browser_client.h:243: virtual void
ClearBrowserCache(RenderViewHost*) = 0;
nit: chrome style is to have parameter names

http://codereview.chromium.org/7322008/diff/4001/content/browser/debugger/dev...
File content/browser/debugger/devtools_handler.cc (right):

http://codereview.chromium.org/7322008/diff/4001/content/browser/debugger/dev...
content/browser/debugger/devtools_handler.cc:12: #include
"content/common/content_client.h"
nit: don't need this

http://codereview.chromium.org/7322008/diff/4001/content/browser/debugger/dev...
File content/browser/debugger/devtools_window.h (right):

http://codereview.chromium.org/7322008/diff/4001/content/browser/debugger/dev...
content/browser/debugger/devtools_window.h:89: virtual
content::JavaScriptDialogCreator* GetJavaScriptDialogCreator();
is this part of a different change?

[vsevik, 2011-07-12 11:30:23]

http://codereview.chromium.org/7322008/diff/4001/chrome/browser/chrome_conten...
> chrome/browser/chrome_content_browser_client.h:105: virtual void
> ClearBrowserCache(RenderViewHost*);
> nit: the "Browser" is redundant
I removed from browser from the method name in ContentBrowserClient, but kept it
in DevTools methods.
 
http://codereview.chromium.org/7322008/diff/4001/content/browser/debugger/dev...
> content/browser/debugger/devtools_window.h:89: virtual
> content::JavaScriptDialogCreator* GetJavaScriptDialogCreator();
> is this part of a different change?
It was related since we need this dialogs for enabling this feature in
inspector, but I moved it out to another changelist.

[jam, 2011-07-12 18:10:55]

lgtm with a green trybot run (which would expose things like
MockContentBrowserClient needing to be updated)

http://codereview.chromium.org/7322008/diff/11001/content/browser/debugger/de...
File content/browser/debugger/devtools_handler.cc (right):

http://codereview.chromium.org/7322008/diff/11001/content/browser/debugger/de...
content/browser/debugger/devtools_handler.cc:102: void
DevToolsHandler::OnClearBrowserCache() {
nit: here too

http://codereview.chromium.org/7322008/diff/11001/content/common/devtools_mes...
File content/common/devtools_messages.h (right):

http://codereview.chromium.org/7322008/diff/11001/content/common/devtools_mes...
content/common/devtools_messages.h:150:
IPC_MESSAGE_ROUTED0(DevToolsHostMsg_ClearBrowserCache)
nit: here too?