content/browser/debugger/devtools_sanity_unittest.cc - Issue 7322004: DevTools: devtools manager should know nothing about DevToolsWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/debugger/devtools_sanity_unittest.cc

Issue 7322004: DevTools: devtools manager should know nothing about DevToolsWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/debugger/devtools_sanity_unittest.cc

diff --git a/content/browser/debugger/devtools_sanity_unittest.cc b/content/browser/debugger/devtools_sanity_unittest.cc

index 365efac836eb1e0cc2740f28cd2dfcbb46642075..fb7f6915526e0543d8aef448c2204ff2a2b74044 100644

--- a/content/browser/debugger/devtools_sanity_unittest.cc

+++ b/content/browser/debugger/devtools_sanity_unittest.cc

@@ -104,12 +104,7 @@ class DevToolsSanityTest : public InProcessBrowserTest {

ui_test_utils::NavigateToURL(browser(), url);

inspected_rvh_ = GetInspectedTab()->render_view_host();

- DevToolsManager* devtools_manager = DevToolsManager::GetInstance();

- devtools_manager->OpenDevToolsWindow(inspected_rvh_);

- DevToolsClientHost* client_host =

- devtools_manager->GetDevToolsClientHostFor(inspected_rvh_);

- window_ = client_host->AsDevToolsWindow();

+ window_ = DevToolsWindow::OpenDevToolsWindow(inspected_rvh_);

RenderViewHost* client_rvh = window_->GetRenderViewHost();

client_contents_ = client_rvh->delegate()->GetAsTabContents();

ui_test_utils::WaitForNavigation(&client_contents_->controller());