Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: content/browser/debugger/devtools_manager.h

Issue 7322004: DevTools: devtools manager should know nothing about DevToolsWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_handler.cc ('k') | content/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/devtools_manager.h
diff --git a/content/browser/debugger/devtools_manager.h b/content/browser/debugger/devtools_manager.h
index 31569ce0a432b12fa330edb8e08c7d71804b5d29..71161b6ae39eb75e9ad4a6e96b2f002886dc2ddb 100644
--- a/content/browser/debugger/devtools_manager.h
+++ b/content/browser/debugger/devtools_manager.h
@@ -53,29 +53,17 @@ class DevToolsManager : public DevToolsClientHost::CloseListener,
DevToolsClientHost* client_host);
void UnregisterDevToolsClientHostFor(RenderViewHost* inspected_rvh);
- void ForwardToDevToolsAgent(RenderViewHost* client_rvh,
- const IPC::Message& message);
void ForwardToDevToolsAgent(DevToolsClientHost* from,
const IPC::Message& message);
void ForwardToDevToolsClient(RenderViewHost* inspected_rvh,
const IPC::Message& message);
- void ActivateWindow(RenderViewHost* client_rvn);
- void CloseWindow(RenderViewHost* client_rvn);
- void RequestDockWindow(RenderViewHost* client_rvn);
- void RequestUndockWindow(RenderViewHost* client_rvn);
-
- void OpenDevToolsWindow(RenderViewHost* inspected_rvh);
- void ToggleDevToolsWindow(RenderViewHost* inspected_rvh,
- DevToolsToggleAction action);
void RuntimePropertyChanged(RenderViewHost* inspected_rvh,
const std::string& name,
const std::string& value);
- // Starts element inspection in the devtools client.
- // Creates one by means of OpenDevToolsWindow if no client
- // exists.
- void InspectElement(RenderViewHost* inspected_rvh, int x, int y);
+ // Starts element inspection in the devtools agent.
+ void SendInspectElement(RenderViewHost* inspected_rvh, int x, int y);
// Sends 'Attach' message to the agent using |dest_rvh| in case
// there is a DevToolsClientHost registered for the |inspected_rvh|.
@@ -121,16 +109,6 @@ class DevToolsManager : public DevToolsClientHost::CloseListener,
void SendAttachToAgent(RenderViewHost* inspected_rvh);
void SendDetachToAgent(RenderViewHost* inspected_rvh);
- void ForceReopenWindow();
-
- DevToolsClientHost* FindOwnerDevToolsClientHost(RenderViewHost* client_rvh);
-
- void ToggleDevToolsWindow(RenderViewHost* inspected_rvh,
- bool force_open,
- DevToolsToggleAction action);
-
- void ReopenWindow(RenderViewHost* client_rvh, bool docked);
-
void BindClientHost(RenderViewHost* inspected_rvh,
DevToolsClientHost* client_host,
const DevToolsRuntimeProperties& runtime_properties);
@@ -156,9 +134,6 @@ class DevToolsManager : public DevToolsClientHost::CloseListener,
RuntimePropertiesMap;
RuntimePropertiesMap runtime_properties_map_;
- RenderViewHost* inspected_rvh_for_reopen_;
- bool in_initial_show_;
-
typedef std::map<int,
std::pair<DevToolsClientHost*, DevToolsRuntimeProperties> >
OrphanClientHosts;
« no previous file with comments | « content/browser/debugger/devtools_handler.cc ('k') | content/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698