chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 7322004: DevTools: devtools manager should know nothing about DevToolsWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 7322004: DevTools: devtools manager should know nothing about DevToolsWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index 39e03b7047bc2bebcd0bfb1ef5d178ecfdcaee01..65fda6ada96a26204a1b7eecc9f2fcba9a03ec86 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -13,7 +13,7 @@

#import "chrome/browser/ui/cocoa/browser_window_cocoa.h"

#import "chrome/browser/ui/cocoa/extensions/extension_view_mac.h"

#import "chrome/browser/ui/cocoa/info_bubble_window.h"

-#include "content/browser/debugger/devtools_manager.h"

+#include "content/browser/debugger/devtools_window.h"

#include "content/common/notification_details.h"

#include "content/common/notification_registrar.h"

#include "content/common/notification_source.h"

@@ -141,7 +141,7 @@ class DevtoolsNotificationBridge : public NotificationObserver {

}

- (void)showDevTools {

- DevToolsManager::GetInstance()->OpenDevToolsWindow(host_->render_view_host());

+ DevToolsWindow::OpenDevToolsWindow(host_->render_view_host());

}

- (void)dealloc {