Issue 7321005: Reduce the number of global constructor calls by changing a constant to a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7321005: Reduce the number of global constructor calls by changing a constant to a (Closed)

Created:
9 years, 5 months ago by Sven Panne

Modified:
9 years, 5 months ago

Reviewers:
Lasse Reichstein, Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reduce the number of global constructor calls by changing a constant to a (constant) inline function. This brings down the size of v8's .ctors section to 1/4, hopefully fixing the recent issues with Chromes' CL 91522. Committed: http://code.google.com/p/v8/source/detail?r=8565

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -26 lines)			Patch
	M	src/conversions.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	src/conversions-inl.h	View	1	17 chunks	+29 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/7321005/diff/1/src/conversions.h File src/conversions.h (right): http://codereview.chromium.org/7321005/diff/1/src/conversions.h#newcode50 src/conversions.h:50: } You can move this function to conversions-inl.h. ...

9 years, 5 months ago (2011-07-07 13:33:01 UTC) #2

Sven Panne

9 years, 5 months ago (2011-07-07 13:55:46 UTC) #3

http://codereview.chromium.org/7321005/diff/1/src/conversions.h
File src/conversions.h (right):

http://codereview.chromium.org/7321005/diff/1/src/conversions.h#newcode50
src/conversions.h:50: }
On 2011/07/07 13:33:01, Lasse Reichstein wrote:
> You can move this function to conversions-inl.h.
> It's the only place it's used.
> And make it inline (just out of principle :).

Done.

Expand Messages | Collapse Messages