Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 7317: Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.... (Closed)

Created:
12 years, 2 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change all ConvertPointTo* methods to use gfx::Point instead of CPoint. http://crbug.com/2186 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3365

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -303 lines) Patch
M base/gfx/point.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/ui_controls.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/find_in_page_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_test.cc View 1 9 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/views/download_tab_view.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/views/frame/browser_view2.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/views/old_frames/simple_xp_frame.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/views/old_frames/vista_frame.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/views/old_frames/xp_frame.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/views/status_bubble.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/views/toolbar_star_toggle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/accessibility/view_accessibility.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/views/bitmap_scroll_bar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/button_dropdown.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/views/chrome_menu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/views/chrome_menu.cc View 13 chunks +41 lines, -40 lines 0 comments Download
M chrome/views/hwnd_view.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/views/hwnd_view_container.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/views/menu_button.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/views/root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/root_view.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/views/root_view_drop_target.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/views/root_view_drop_target.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/views/tooltip_manager.cc View 8 chunks +21 lines, -20 lines 0 comments Download
M chrome/views/tree_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/views/view.h View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/views/view.cc View 4 chunks +20 lines, -41 lines 0 comments Download
M chrome/views/view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
12 years, 2 months ago (2008-10-14 20:03:50 UTC) #1
Elliot Glaysher
12 years, 2 months ago (2008-10-14 20:57:38 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698