Restore NOTREACHED() in WebKitClientImpl::loadResource()

webkit/glue/webkitclient_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webkitclient_impl.h"
 
 #if defined(OS_LINUX)
 #include <malloc.h>
 #endif
 
@@ skipping 328 matching lines @@
     base::StringPiece resource =
         GetDataResource(kFirstAudioResourceIndex + resource_index);
     return WebData(resource.data(), resource.size());
   }
 #endif  // IDR_AUDIO_SPATIALIZATION_T000_P000
 
   NOTREACHED();
   return WebData();
 }
 
+struct DataResource {
+  const char* name;
+  int id;
+};
+
+const DataResource kDataResources[] = {
+  { "missingImage", IDR_BROKENIMAGE },
+  { "mediaPause", IDR_MEDIA_PAUSE_BUTTON },
+  { "mediaPlay", IDR_MEDIA_PLAY_BUTTON },
+  { "mediaPlayDisabled", IDR_MEDIA_PLAY_BUTTON_DISABLED },
+  { "mediaSoundDisabled", IDR_MEDIA_SOUND_DISABLED },
+  { "mediaSoundFull", IDR_MEDIA_SOUND_FULL_BUTTON },
+  { "mediaSoundNone", IDR_MEDIA_SOUND_NONE_BUTTON },
+  { "mediaSliderThumb", IDR_MEDIA_SLIDER_THUMB },
+  { "mediaVolumeSliderThumb", IDR_MEDIA_VOLUME_SLIDER_THUMB },
+  { "panIcon", IDR_PAN_SCROLL_ICON },
+  { "searchCancel", IDR_SEARCH_CANCEL },
+  { "searchCancelPressed", IDR_SEARCH_CANCEL_PRESSED },
+  { "searchMagnifier", IDR_SEARCH_MAGNIFIER },
+  { "searchMagnifierResults", IDR_SEARCH_MAGNIFIER_RESULTS },
+  { "textAreaResizeCorner", IDR_TEXTAREA_RESIZER },
+  { "tickmarkDash", IDR_TICKMARK_DASH },
+  { "inputSpeech", IDR_INPUT_SPEECH },
+  { "inputSpeechRecording", IDR_INPUT_SPEECH_RECORDING },
+  { "inputSpeechWaiting", IDR_INPUT_SPEECH_WAITING },
+  { "americanExpressCC", IDR_AUTOFILL_CC_AMEX },
+  { "dinersCC", IDR_AUTOFILL_CC_DINERS },
+  { "discoverCC", IDR_AUTOFILL_CC_DISCOVER },
+  { "genericCC", IDR_AUTOFILL_CC_GENERIC },
+  { "jcbCC", IDR_AUTOFILL_CC_JCB },
+  { "masterCardCC", IDR_AUTOFILL_CC_MASTERCARD },
+  { "soloCC", IDR_AUTOFILL_CC_SOLO },
+  { "visaCC", IDR_AUTOFILL_CC_VISA },
+};
+
 }  // namespace
 
 WebData WebKitClientImpl::loadResource(const char* name) {
-  struct {
-    const char* name;
-    int id;
-  } resources[] = {
-    { "missingImage", IDR_BROKENIMAGE },
-    { "mediaPause", IDR_MEDIA_PAUSE_BUTTON },
-    { "mediaPlay", IDR_MEDIA_PLAY_BUTTON },
-    { "mediaPlayDisabled", IDR_MEDIA_PLAY_BUTTON_DISABLED },
-    { "mediaSoundDisabled", IDR_MEDIA_SOUND_DISABLED },
-    { "mediaSoundFull", IDR_MEDIA_SOUND_FULL_BUTTON },
-    { "mediaSoundNone", IDR_MEDIA_SOUND_NONE_BUTTON },
-    { "mediaSliderThumb", IDR_MEDIA_SLIDER_THUMB },
-    { "mediaVolumeSliderThumb", IDR_MEDIA_VOLUME_SLIDER_THUMB },
-    { "panIcon", IDR_PAN_SCROLL_ICON },
-    { "searchCancel", IDR_SEARCH_CANCEL },
-    { "searchCancelPressed", IDR_SEARCH_CANCEL_PRESSED },
-    { "searchMagnifier", IDR_SEARCH_MAGNIFIER },
-    { "searchMagnifierResults", IDR_SEARCH_MAGNIFIER_RESULTS },
-    { "textAreaResizeCorner", IDR_TEXTAREA_RESIZER },
-    { "tickmarkDash", IDR_TICKMARK_DASH },
-    { "inputSpeech", IDR_INPUT_SPEECH },
-    { "inputSpeechRecording", IDR_INPUT_SPEECH_RECORDING },
-    { "inputSpeechWaiting", IDR_INPUT_SPEECH_WAITING },
-    { "americanExpressCC", IDR_AUTOFILL_CC_AMEX },
-    { "dinersCC", IDR_AUTOFILL_CC_DINERS },
-    { "discoverCC", IDR_AUTOFILL_CC_DISCOVER },
-    { "genericCC", IDR_AUTOFILL_CC_GENERIC },
-    { "jcbCC", IDR_AUTOFILL_CC_JCB },
-    { "masterCardCC", IDR_AUTOFILL_CC_MASTERCARD },
-    { "soloCC", IDR_AUTOFILL_CC_SOLO },
-    { "visaCC", IDR_AUTOFILL_CC_VISA },
-  };
+  if (!strlen(name))

[James Hawkins, 2011/07/07 20:47:37]

Add a comment for why this may happen.

[Ilya Sherman, 2011/07/07 20:51:49]

Done.

+    return WebData();
 
   // Check the name prefix to see if it's an audio resource.
-  if (StartsWithASCII(name, "IRC_Composite", true)) {
+  if (StartsWithASCII(name, "IRC_Composite", true))
     return loadAudioSpatializationResource(name);
-  } else {
-    for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
-      if (!strcmp(name, resources[i].name)) {
-        base::StringPiece resource = GetDataResource(resources[i].id);
-        return WebData(resource.data(), resource.size());
-      }
+
+  for (size_t i = 0; i < arraysize(kDataResources); ++i) {
+    if (!strcmp(name, kDataResources[i].name)) {
+      base::StringPiece resource = GetDataResource(kDataResources[i].id);
+      return WebData(resource.data(), resource.size());
     }
   }
-  // TODO(jhawkins): Restore this NOTREACHED once WK stops sending in empty
-  // strings. http://crbug.com/50675.
-  //NOTREACHED() << "Unknown image resource " << name;
+
+  NOTREACHED() << "Unknown image resource " << name;
   return WebData();
 }
 
 bool WebKitClientImpl::loadAudioResource(
     WebKit::WebAudioBus* destination_bus, const char* audio_file_data,
     size_t data_size, double sample_rate) {
   return DecodeAudioFileData(destination_bus,
                              audio_file_data,
                              data_size,
                              sample_rate);
@@ skipping 190 matching lines @@
   ++shared_timer_suspended_;
 }
 
 void WebKitClientImpl::ResumeSharedTimer() {
   // The shared timer may have fired or been adjusted while we were suspended.
   if (--shared_timer_suspended_ == 0 && !shared_timer_.IsRunning())
     setSharedTimerFireTime(shared_timer_fire_time_);
 }
 
 }  // namespace webkit_glue