Issue 7316018: Ensure that regexps always have code object, even if GC happened while running multiple times in ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7316018: Ensure that regexps always have code object, even if GC happened while running multiple times in ... (Closed)

Created:
9 years, 5 months ago by Rico

Modified:
9 years, 5 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Ensure that regexps always have code object, even if GC happened while running multiple times in runtime. Committed: http://code.google.com/p/v8/source/detail?r=8560

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -0 lines)			Patch
	M	src/jsregexp.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-regexp-codeflush.js	View		1 chunk	+55 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Erik Corry

LGTM Did you grep for other places with IrregexpNativeCode?

9 years, 5 months ago (2011-07-07 08:05:44 UTC) #2

Rico

9 years, 5 months ago (2011-07-07 09:09:15 UTC) #3

On 2011/07/07 08:05:44, Erik Corry wrote:
> LGTM
> 
> Did you grep for other places with IrregexpNativeCode?

Yep, this is the only place it is used.