Support Closure in ALL the loops!

base/message_loop_proxy_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop_proxy_impl.h"
 #include "base/threading/thread_restrictions.h"
 
 namespace base {
 
 MessageLoopProxyImpl::~MessageLoopProxyImpl() {
@@ skipping 22 matching lines @@
   return PostTaskHelper(from_here, task, 0, false);
 }
 
 bool MessageLoopProxyImpl::PostNonNestableDelayedTask(
     const tracked_objects::Location& from_here,
     Task* task,
     int64 delay_ms) {
   return PostTaskHelper(from_here, task, delay_ms, false);
 }
 
+bool MessageLoopProxyImpl::PostTask(const tracked_objects::Location& from_here,
+                                    const base::Closure& task) {
+  return PostTaskHelper(from_here, task, 0, true);
+}
+
+bool MessageLoopProxyImpl::PostDelayedTask(
+    const tracked_objects::Location& from_here,
+    const base::Closure& task,
+    int64 delay_ms) {
+  return PostTaskHelper(from_here, task, delay_ms, true);
+}
+
+bool MessageLoopProxyImpl::PostNonNestableTask(
+    const tracked_objects::Location& from_here, const base::Closure& task) {
+  return PostTaskHelper(from_here, task, 0, false);
+}
+
+bool MessageLoopProxyImpl::PostNonNestableDelayedTask(
+    const tracked_objects::Location& from_here,
+    const base::Closure& task,
+    int64 delay_ms) {
+  return PostTaskHelper(from_here, task, delay_ms, false);
+}
+
 bool MessageLoopProxyImpl::BelongsToCurrentThread() {
   // We shouldn't use MessageLoop::current() since it uses LazyInstance which
   // may be deleted by ~AtExitManager when a WorkerPool thread calls this
   // function.
   // http://crbug.com/63678
   base::ThreadRestrictions::ScopedAllowSingleton allow_singleton;
   AutoLock lock(message_loop_lock_);
   return (target_message_loop_ &&
           (MessageLoop::current() == target_message_loop_));
 }
@@ skipping 42 matching lines @@
                                                          delay_ms);
       }
       ret = true;
     }
   }
   if (!ret)
     delete task;
   return ret;
 }
 
+bool MessageLoopProxyImpl::PostTaskHelper(
+    const tracked_objects::Location& from_here, const base::Closure& task,
+    int64 delay_ms, bool nestable) {
+  bool ret = false;
+  {

[darin (slow to review), 2011/07/07 21:54:01]

the extra nesting here can be removed.  it only existed above so that we would
avoid deleting the task while holding the message loop lock.

[awong, 2011/07/08 00:38:40]

Done.

+    AutoLock lock(message_loop_lock_);
+    if (target_message_loop_) {
+      if (nestable) {
+        target_message_loop_->PostDelayedTask(from_here, task, delay_ms);
+      } else {
+        target_message_loop_->PostNonNestableDelayedTask(from_here, task,
+                                                         delay_ms);
+      }
+      ret = true;
+    }
+  }
+  return ret;
+}
+
 scoped_refptr<MessageLoopProxy>
 MessageLoopProxy::CreateForCurrentThread() {
   scoped_refptr<MessageLoopProxy> ret(new MessageLoopProxyImpl());
   return ret;
 }
 
 }  // namespace base