Issue 7316013: history: Move kBookmarkBarID constant out of HistoryService.

Issue 7316013: history: Move kBookmarkBarID constant out of HistoryService. (Closed)

Created:
9 years, 5 months ago by tfarina

Modified:
9 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

history: Move kBookmarkBarID constant out of HistoryService. BUG=None TEST=unit_tests R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91725

Patch Set 3 : after friends #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -19 lines)			Patch
M	chrome/browser/history/history.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/history/starred_url_database.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/history/starred_url_database.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/history/starred_url_database_unittest.cc	View		7 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/7316013/diff/1/chrome/browser/history/starred_url_database.h File chrome/browser/history/starred_url_database.h (right): http://codereview.chromium.org/7316013/diff/1/chrome/browser/history/starred_url_database.h#newcode28 chrome/browser/history/starred_url_database.h:28: extern const int64 kBookmarkBarID; This should be a static ...

9 years, 5 months ago (2011-07-07 15:37:02 UTC) #2

tfarina

9 years, 5 months ago (2011-07-07 16:19:50 UTC) #3

sky

LGTM http://codereview.chromium.org/7316013/diff/4001/chrome/browser/history/starred_url_database.h File chrome/browser/history/starred_url_database.h (right): http://codereview.chromium.org/7316013/diff/4001/chrome/browser/history/starred_url_database.h#newcode39 chrome/browser/history/starred_url_database.h:39: static const int64 kBookmarkBarID; Move this after friends.

9 years, 5 months ago (2011-07-07 17:07:53 UTC) #4

tfarina

9 years, 5 months ago (2011-07-07 17:42:20 UTC) #5

http://codereview.chromium.org/7316013/diff/4001/chrome/browser/history/starr...
File chrome/browser/history/starred_url_database.h (right):

http://codereview.chromium.org/7316013/diff/4001/chrome/browser/history/starr...
chrome/browser/history/starred_url_database.h:39: static const int64
kBookmarkBarID;
On 2011/07/07 17:07:53, sky wrote:
> Move this after friends.

Done.

Expand Messages | Collapse Messages