Issue 7315002: Changes menu button to not show the menu on alt-space. alt-space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7315002: Changes menu button to not show the menu on alt-space. alt-space (Closed)

Created:
9 years, 5 months ago by sky

Modified:
9 years, 5 months ago

Reviewers:
Peter Kasting, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Changes menu button to not show the menu on alt-space. alt-space should show the window menu, so that if menu button consumes this event the window menu is never shown. BUG=56650 TEST=press alt and release, focus should be on the wrench. press alt-space, make sure the window menu appears, not the wrench menu. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91604

Patch Set 1 #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	views/controls/button/menu_button.cc	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

9 years, 5 months ago (2011-07-06 17:47:46 UTC) #3

http://codereview.chromium.org/7315002/diff/1/views/controls/button/menu_butt...
File views/controls/button/menu_button.cc (right):

http://codereview.chromium.org/7315002/diff/1/views/controls/button/menu_butt...
views/controls/button/menu_button.cc:225: // alt-space on windows should show
the window menu.
Tiny nit: Capitalize!

(Also, this would be shorter and maybe fractionally better if the comment went
above the conditional, and the {} disappeared.)

Expand Messages | Collapse Messages