Issue 7314021: Clean up .gypi and no-op GetCompositingSurface on TOUCH_UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7314021: Clean up .gypi and no-op GetCompositingSurface on TOUCH_UI. (Closed)

Created:
9 years, 5 months ago by jonathan.backer

Modified:
9 years, 5 months ago

Reviewers:
sky, Ben Goodger (Google)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean up .gypi and no-op GetCompositingSurface on TOUCH_UI. GetCompositingSurface should just return a non-zero value on TOUCH_UI because we use a very different accelerated drawing path. In particular, the GPU process renders offscreen (to a region that it creates) and passes a handle to the video memory for the browser to display. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91712

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views_touch.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jonathan.backer

This patch is part of a broader set that will allow me to accelerate the ...

9 years, 5 months ago (2011-07-07 13:50:04 UTC) #1

LGTM

Expand Messages | Collapse Messages