Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4242)

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/core_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc
index 83cdafa169140d591d45b0edcfcb4be46c0c9d1b..1980624a308bb6216c2bbb1f6d5d46d5d24ba84f 100644
--- a/chrome/browser/ui/webui/options/core_options_handler.cc
+++ b/chrome/browser/ui/webui/options/core_options_handler.cc
@@ -181,7 +181,7 @@ void CoreOptionsHandler::ClearPref(const std::string& pref_name,
pref_service->ScheduleSavePersistentPrefs();
if (!metric.empty())
- UserMetricsRecordAction(UserMetricsAction(metric.c_str()));
+ UserMetrics::RecordComputedAction(metric);
}
void CoreOptionsHandler::ProcessUserMetric(const Value* value,
@@ -196,7 +196,7 @@ void CoreOptionsHandler::ProcessUserMetric(const Value* value,
metric_string += bool_value ? "_Enable" : "_Disable";
}
- UserMetricsRecordAction(UserMetricsAction(metric_string.c_str()));
+ UserMetrics::RecordComputedAction(metric_string);
}
void CoreOptionsHandler::StopObservingPref(const std::string& path) {
@@ -346,7 +346,7 @@ void CoreOptionsHandler::HandleClearPref(const ListValue* args) {
void CoreOptionsHandler::HandleUserMetricsAction(const ListValue* args) {
std::string metric = UTF16ToUTF8(ExtractStringValue(args));
if (!metric.empty())
- UserMetricsRecordAction(UserMetricsAction(metric.c_str()));
+ UserMetrics::RecordComputedAction(metric);
}
void CoreOptionsHandler::UpdateClearPluginLSOData() {

Powered by Google App Engine
This is Rietveld 408576698