Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4820)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index ae074e772b3e73b66b4f19e957ed49c7a52f56e5..7eff218d8ffe4b60ad9dd98284554ca43736b592 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1846,18 +1846,11 @@ void Browser::OpenCreateShortcutsDialog() {
}
void Browser::ToggleDevToolsWindow(DevToolsToggleAction action) {
- std::string uma_string;
- switch (action) {
- case DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE:
- uma_string = "DevTools_ToggleConsole";
- break;
- case DEVTOOLS_TOGGLE_ACTION_NONE:
- case DEVTOOLS_TOGGLE_ACTION_INSPECT:
- default:
- uma_string = "DevTools_ToggleWindow";
- break;
- }
- UserMetrics::RecordAction(UserMetricsAction(uma_string.c_str()));
+ if (action == DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE)
+ UserMetrics::RecordAction(UserMetricsAction("DevTools_ToggleConsole"));
+ else
+ UserMetrics::RecordAction(UserMetricsAction("DevTools_ToggleWindow"));
+
DevToolsManager::GetInstance()->ToggleDevToolsWindow(
GetSelectedTabContentsWrapper()->render_view_host(), action);
}

Powered by Google App Engine
This is Rietveld 408576698