Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update regex Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 2c51194fd129aecb50799a8cf49df8b6984b054d..2bab79f17198e500827ae53256aec8cd2d48c804 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1918,18 +1918,11 @@ void Browser::OpenCreateShortcutsDialog() {
}
void Browser::ToggleDevToolsWindow(DevToolsToggleAction action) {
- std::string uma_string;
- switch (action) {
- case DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE:
- uma_string = "DevTools_ToggleConsole";
- break;
- case DEVTOOLS_TOGGLE_ACTION_NONE:
- case DEVTOOLS_TOGGLE_ACTION_INSPECT:
- default:
- uma_string = "DevTools_ToggleWindow";
- break;
- }
- UserMetrics::RecordAction(UserMetricsAction(uma_string.c_str()));
+ if (action == DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE)
+ UserMetrics::RecordAction(UserMetricsAction("DevTools_ToggleConsole"));
+ else
+ UserMetrics::RecordAction(UserMetricsAction("DevTools_ToggleWindow"));
+
DevToolsWindow::ToggleDevToolsWindow(
GetSelectedTabContentsWrapper()->render_view_host(), action);
}
« no previous file with comments | « chrome/browser/resources/options/search_page.html ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698