Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/ui/webui/options/options_ui.cc

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update regex Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/options_ui.h" 5 #include "chrome/browser/ui/webui/options/options_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 OptionsPageUIHandler::OptionsPageUIHandler() { 153 OptionsPageUIHandler::OptionsPageUIHandler() {
154 } 154 }
155 155
156 OptionsPageUIHandler::~OptionsPageUIHandler() { 156 OptionsPageUIHandler::~OptionsPageUIHandler() {
157 } 157 }
158 158
159 bool OptionsPageUIHandler::IsEnabled() { 159 bool OptionsPageUIHandler::IsEnabled() {
160 return true; 160 return true;
161 } 161 }
162 162
163 void OptionsPageUIHandler::UserMetricsRecordAction(
164 const UserMetricsAction& action) {
165 UserMetrics::RecordAction(action);
166 }
167
168 // static 163 // static
169 void OptionsPageUIHandler::RegisterStrings( 164 void OptionsPageUIHandler::RegisterStrings(
170 DictionaryValue* localized_strings, 165 DictionaryValue* localized_strings,
171 const OptionsStringResource* resources, 166 const OptionsStringResource* resources,
172 size_t length) { 167 size_t length) {
173 for (size_t i = 0; i < length; ++i) { 168 for (size_t i = 0; i < length; ++i) {
174 localized_strings->SetString( 169 localized_strings->SetString(
175 resources[i].name, l10n_util::GetStringUTF16(resources[i].id)); 170 resources[i].name, l10n_util::GetStringUTF16(resources[i].id));
176 } 171 }
177 } 172 }
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 OptionsPageUIHandler* handler_raw) { 336 OptionsPageUIHandler* handler_raw) {
342 scoped_ptr<OptionsPageUIHandler> handler(handler_raw); 337 scoped_ptr<OptionsPageUIHandler> handler(handler_raw);
343 DCHECK(handler.get()); 338 DCHECK(handler.get());
344 // Add only if handler's service is enabled. 339 // Add only if handler's service is enabled.
345 if (handler->IsEnabled()) { 340 if (handler->IsEnabled()) {
346 handler->GetLocalizedValues(localized_strings); 341 handler->GetLocalizedValues(localized_strings);
347 // Add handler to the list and also pass the ownership. 342 // Add handler to the list and also pass the ownership.
348 AddMessageHandler(handler.release()->Attach(this)); 343 AddMessageHandler(handler.release()->Attach(this));
349 } 344 }
350 } 345 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/options/options_ui.h ('k') | chrome/browser/ui/webui/options/personal_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698