Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update regex Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 1900 matching lines...) Expand 10 before | Expand all | Expand 10 after
1911 1911
1912 // Start fetching web app info for CreateApplicationShortcut dialog and show 1912 // Start fetching web app info for CreateApplicationShortcut dialog and show
1913 // the dialog when the data is available in OnDidGetApplicationInfo. 1913 // the dialog when the data is available in OnDidGetApplicationInfo.
1914 current_tab->extension_tab_helper()->GetApplicationInfo(entry->page_id()); 1914 current_tab->extension_tab_helper()->GetApplicationInfo(entry->page_id());
1915 #else 1915 #else
1916 NOTIMPLEMENTED(); 1916 NOTIMPLEMENTED();
1917 #endif 1917 #endif
1918 } 1918 }
1919 1919
1920 void Browser::ToggleDevToolsWindow(DevToolsToggleAction action) { 1920 void Browser::ToggleDevToolsWindow(DevToolsToggleAction action) {
1921 std::string uma_string; 1921 if (action == DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE)
1922 switch (action) { 1922 UserMetrics::RecordAction(UserMetricsAction("DevTools_ToggleConsole"));
1923 case DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE: 1923 else
1924 uma_string = "DevTools_ToggleConsole"; 1924 UserMetrics::RecordAction(UserMetricsAction("DevTools_ToggleWindow"));
1925 break; 1925
1926 case DEVTOOLS_TOGGLE_ACTION_NONE:
1927 case DEVTOOLS_TOGGLE_ACTION_INSPECT:
1928 default:
1929 uma_string = "DevTools_ToggleWindow";
1930 break;
1931 }
1932 UserMetrics::RecordAction(UserMetricsAction(uma_string.c_str()));
1933 DevToolsWindow::ToggleDevToolsWindow( 1926 DevToolsWindow::ToggleDevToolsWindow(
1934 GetSelectedTabContentsWrapper()->render_view_host(), action); 1927 GetSelectedTabContentsWrapper()->render_view_host(), action);
1935 } 1928 }
1936 1929
1937 void Browser::OpenTaskManager(bool highlight_background_resources) { 1930 void Browser::OpenTaskManager(bool highlight_background_resources) {
1938 UserMetrics::RecordAction(UserMetricsAction("TaskManager")); 1931 UserMetrics::RecordAction(UserMetricsAction("TaskManager"));
1939 if (highlight_background_resources) 1932 if (highlight_background_resources)
1940 window_->ShowBackgroundPages(); 1933 window_->ShowBackgroundPages();
1941 else 1934 else
1942 window_->ShowTaskManager(); 1935 window_->ShowTaskManager();
(...skipping 2909 matching lines...) Expand 10 before | Expand all | Expand 10 after
4852 } 4845 }
4853 4846
4854 void Browser::ShowSyncSetup() { 4847 void Browser::ShowSyncSetup() {
4855 ProfileSyncService* service = 4848 ProfileSyncService* service =
4856 profile()->GetOriginalProfile()->GetProfileSyncService(); 4849 profile()->GetOriginalProfile()->GetProfileSyncService();
4857 if (service->HasSyncSetupCompleted()) 4850 if (service->HasSyncSetupCompleted())
4858 ShowOptionsTab(chrome::kSyncSetupSubPage); 4851 ShowOptionsTab(chrome::kSyncSetupSubPage);
4859 else 4852 else
4860 service->ShowLoginDialog(); 4853 service->ShowLoginDialog();
4861 } 4854 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/search_page.html ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698