Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 7314017: clang: Fix a comment pointing to app_unittests instead of ui_unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A general interface for filtering and only acting on classes in Chromium C++ 5 // A general interface for filtering and only acting on classes in Chromium C++
6 // code. 6 // code.
7 7
8 #include "ChromeClassTester.h" 8 #include "ChromeClassTester.h"
9 9
10 #include <sys/param.h> 10 #include <sys/param.h>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 ignored_record_names_.insert("AutocompleteController"); 120 ignored_record_names_.insert("AutocompleteController");
121 ignored_record_names_.insert("HistoryURLProvider"); 121 ignored_record_names_.insert("HistoryURLProvider");
122 122
123 // Because of chrome frame 123 // Because of chrome frame
124 ignored_record_names_.insert("ReliabilityTestSuite"); 124 ignored_record_names_.insert("ReliabilityTestSuite");
125 125
126 // Used over in the net unittests. A large enough bundle of integers with 1 126 // Used over in the net unittests. A large enough bundle of integers with 1
127 // non-pod class member. Probably harmless. 127 // non-pod class member. Probably harmless.
128 ignored_record_names_.insert("MockTransaction"); 128 ignored_record_names_.insert("MockTransaction");
129 129
130 // Used heavily in app_unittests and once in views_unittests. Fixing this 130 // Used heavily in ui_unittests and once in views_unittests. Fixing this
131 // isn't worth the overhead of an additional library. 131 // isn't worth the overhead of an additional library.
132 ignored_record_names_.insert("TestAnimationDelegate"); 132 ignored_record_names_.insert("TestAnimationDelegate");
133 133
134 // Part of our public interface that nacl and friends use. (Arguably, this 134 // Part of our public interface that nacl and friends use. (Arguably, this
135 // should mean that this is a higher priority but fixing this looks hard.) 135 // should mean that this is a higher priority but fixing this looks hard.)
136 ignored_record_names_.insert("PluginVersionInfo"); 136 ignored_record_names_.insert("PluginVersionInfo");
137 } 137 }
138 138
139 ChromeClassTester::~ChromeClassTester() {} 139 ChromeClassTester::~ChromeClassTester() {}
140 140
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 } 278 }
279 } 279 }
280 } 280 }
281 281
282 return false; 282 return false;
283 } 283 }
284 284
285 bool ChromeClassTester::IsIgnoredType(const std::string& base_name) { 285 bool ChromeClassTester::IsIgnoredType(const std::string& base_name) {
286 return ignored_record_names_.find(base_name) != ignored_record_names_.end(); 286 return ignored_record_names_.find(base_name) != ignored_record_names_.end();
287 } 287 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698