Issue 7314001: [cros] Return needs_new_plan() = true only if data plan is supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7314001: [cros] Return needs_new_plan() = true only if data plan is supported. (Closed)

Created:
9 years, 5 months ago by Nikita (slow)

Modified:
9 years, 5 months ago

Reviewers:
stevenjb, Charlie Lee, commit-bot: I haz the power, zel

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Return needs_new_plan() = true only if data plan is supported. This will fix cases when cellular network is in restricted pool (i.e. in roaming w/o data connectivity) but doesn't support data plan (not Verizon). BUG=chromium-os:16000, 16730 TEST=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91596

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/chromeos/cros/network_library.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Charlie, this should fix and "Buy plan" button wouldn't be displayed. Steven, please review if ...

9 years, 5 months ago (2011-07-06 12:04:18 UTC) #1

Change committed as 91596

Expand Messages | Collapse Messages