Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/lithium-allocator.cc

Issue 7313023: When resolving phies use ANY instead of NONE as a policy for phi operands. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1006 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 LUnallocated* phi_operand = new LUnallocated(LUnallocated::NONE); 1017 LUnallocated* phi_operand = new LUnallocated(LUnallocated::NONE);
1018 phi_operand->set_virtual_register(phi->id()); 1018 phi_operand->set_virtual_register(phi->id());
1019 for (int j = 0; j < phi->OperandCount(); ++j) { 1019 for (int j = 0; j < phi->OperandCount(); ++j) {
1020 HValue* op = phi->OperandAt(j); 1020 HValue* op = phi->OperandAt(j);
1021 LOperand* operand = NULL; 1021 LOperand* operand = NULL;
1022 if (op->IsConstant() && op->EmitAtUses()) { 1022 if (op->IsConstant() && op->EmitAtUses()) {
1023 HConstant* constant = HConstant::cast(op); 1023 HConstant* constant = HConstant::cast(op);
1024 operand = chunk_->DefineConstantOperand(constant); 1024 operand = chunk_->DefineConstantOperand(constant);
1025 } else { 1025 } else {
1026 ASSERT(!op->EmitAtUses()); 1026 ASSERT(!op->EmitAtUses());
1027 LUnallocated* unalloc = new LUnallocated(LUnallocated::NONE); 1027 LUnallocated* unalloc = new LUnallocated(LUnallocated::ANY);
1028 unalloc->set_virtual_register(op->id()); 1028 unalloc->set_virtual_register(op->id());
1029 operand = unalloc; 1029 operand = unalloc;
1030 } 1030 }
1031 HBasicBlock* cur_block = block->predecessors()->at(j); 1031 HBasicBlock* cur_block = block->predecessors()->at(j);
1032 // The gap move must be added without any special processing as in 1032 // The gap move must be added without any special processing as in
1033 // the AddConstraintsGapMove. 1033 // the AddConstraintsGapMove.
1034 chunk_->AddGapMove(cur_block->last_instruction_index() - 1, 1034 chunk_->AddGapMove(cur_block->last_instruction_index() - 1,
1035 operand, 1035 operand,
1036 phi_operand); 1036 phi_operand);
1037 1037
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
2119 LiveRange* current = live_ranges()->at(i); 2119 LiveRange* current = live_ranges()->at(i);
2120 if (current != NULL) current->Verify(); 2120 if (current != NULL) current->Verify();
2121 } 2121 }
2122 } 2122 }
2123 2123
2124 2124
2125 #endif 2125 #endif
2126 2126
2127 2127
2128 } } // namespace v8::internal 2128 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698