Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 7313019: Actually call psm::RegisterDynamicOids(). (Closed)

Created:
9 years, 5 months ago by wtc
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Actually call psm::RegisterDynamicOids(). Register the OIDs for the businessCategory and incorporationCountry attributes. Add a case for SEC_OID_UNKNOWN as a safety net. R=mattm@chromium.org BUG=88612 TEST=On Linux, visit https://servicios.izenpe.com/ and view the certificate. The subject field should have: businessCategory = Business Entity incorporationCountry = ES Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91722

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/net/x509_certificate_model_nss.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp View 5 chunks +17 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
wtc
http://codereview.chromium.org/7313019/diff/1/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp File chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp (left): http://codereview.chromium.org/7313019/diff/1/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp#oldcode128 chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp:128: ms_nt_principal_name = RegisterDynamicOid("1.3.6.1.4.1.311.25.1"); This must have been a copy-and-paste ...
9 years, 5 months ago (2011-07-07 02:22:50 UTC) #1
mattm
LGTM
9 years, 5 months ago (2011-07-07 02:34:01 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 17:02:21 UTC) #3
Change committed as 91722

Powered by Google App Engine
This is Rietveld 408576698