Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 7313017: Convert remaining instances of the 'os' variable in grit conditions (Closed)

Created:
9 years, 5 months ago by tony
Modified:
9 years, 5 months ago
Reviewers:
ruben, Jói
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Convert remaining instances of the 'os' variable in grit conditions to the new easier to read variables. BUG=none TEST=Manual, everything still compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M chrome/app/chromium_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 28 chunks +33 lines, -33 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/policy/policy_templates.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/theme/theme_resources.grd View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/app/theme/theme_resources_large.grd View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/base/strings/app_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gfx_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
9 years, 5 months ago (2011-07-07 19:02:14 UTC) #1
ruben
LGTM
9 years, 5 months ago (2011-07-07 19:25:50 UTC) #2
Jói
9 years, 5 months ago (2011-07-07 19:50:06 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698