Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 7313005: [cros] Hide chrome://mobilesetup content on non-supported networks. (Closed)

Created:
9 years, 5 months ago by Nikita (slow)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, Eric Shienbrood
Visibility:
Public.

Description

[cros] Hide chrome://mobilesetup content on non-supported networks. Don't start activation process if network doesn't support that. BUG=chrome-os-partner:4652 TEST=Manual. Navigated to chrome://mobilesetup on GSM network. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91724

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/chromeos/cros/network_library.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nikita (slow)
Related http://codereview.chromium.org/7314001/
9 years, 5 months ago (2011-07-06 15:37:52 UTC) #1
Nikita (slow)
Sorry, I've sent review to incorrect email.
9 years, 5 months ago (2011-07-07 13:44:57 UTC) #2
zel
LGTM http://codereview.chromium.org/7313005/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right): http://codereview.chromium.org/7313005/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc#newcode479 chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:479: LoadCellularConfig(); you can probably do all this before ...
9 years, 5 months ago (2011-07-07 16:30:56 UTC) #3
Nikita (slow)
http://codereview.chromium.org/7313005/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right): http://codereview.chromium.org/7313005/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc#newcode479 chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:479: LoadCellularConfig(); On 2011/07/07 16:30:56, zel wrote: > you can ...
9 years, 5 months ago (2011-07-07 16:49:14 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 17:42:32 UTC) #5
Change committed as 91724

Powered by Google App Engine
This is Rietveld 408576698