Issue 7312028: Fixing signed/unsigned char bug on ARM for TouchFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7312028: Fixing signed/unsigned char bug on ARM for TouchFactory (Closed)

Created:
9 years, 5 months ago by Yufeng Shen (Slow to review)

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, sadrul, sky

CC:
chromium-reviews, dhollowa

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fixing signed/unsigned char bug on ARM for TouchFactory Change the type of valuator_lookup_[kMaxDeviceNum][TP_LAST_ENTRY] from "char" to "signed char". -1 is set for valuator_lookup_[][] for invalid entry. Some ARM platform/cross-compiler defaults "char" as "unsigned char" which does not accommodate negative value -1. Fixing it by specifically setting the type to "signed char". BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91736

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	views/touchui/touch_factory.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Change committed as 91736

Expand Messages | Collapse Messages