Issue 7312022: Don't emit a write barrier when storing boolean-typed values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7312022: Don't emit a write barrier when storing boolean-typed values. (Closed)

Created:
9 years, 5 months ago by fschneider

Modified:
9 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Don't emit a write barrier when storing boolean-typed values. Committed: http://code.google.com/p/v8/source/detail?r=8561

Patch Set 1 #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 5 months ago (2011-07-07 10:13:44 UTC) #3

LGTM.

http://codereview.chromium.org/7312022/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7312022/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:3366: && !value->type().IsSmi()
OK.  The predicate here would be easier to read if it was negated, but maybe
that's less good at the call sites.

Expand Messages | Collapse Messages