Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 7312014: GTK: Hide the "Other Bookmarks" button when there are no bookmarks there. (Closed)

Created:
9 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Hide the "Other Bookmarks" button when there are no bookmarks there. We now match the windows behaviour. BUG=64997 TEST=As in bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91631

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 5 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
9 years, 5 months ago (2011-07-06 21:14:21 UTC) #1
Evan Martin
LGTM (an alternative approach is to put the separator+button in a hbox widget and then ...
9 years, 5 months ago (2011-07-06 21:22:33 UTC) #2
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc ...
9 years, 5 months ago (2011-07-06 21:30:34 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-07-06 22:50:37 UTC) #4
Change committed as 91631

Powered by Google App Engine
This is Rietveld 408576698