Minor cleanups in JingleSession and JingleSessionManager.

remoting/protocol/jingle_session.cc

Index: remoting/protocol/jingle_session.cc
diff --git a/remoting/protocol/jingle_session.cc b/remoting/protocol/jingle_session.cc
index 9d3fea6f144940d8fee1f47b9f42b15c63e06a3a..5db43eea009111273f59eda853c07182840d9477 100644
--- a/remoting/protocol/jingle_session.cc
+++ b/remoting/protocol/jingle_session.cc
@@ -159,7 +159,7 @@ JingleSession::JingleSession(
 }
 
 JingleSession::~JingleSession() {
-  DCHECK(closed_);
+  Close();

[Wez, 2011/07/06 21:24:25]

Is this safe?  Isn't it possible for |cricket_session_| to call back in to this
JingleSession after Terminate() has completed?

[Sergey Ulanov, 2011/07/06 23:15:01]

It may. Added line that resets |state_change_callback_| so that we don't call it
while being destructed.

[Wez, 2011/07/06 23:39:41]

Actually, I think the only way to be sure that you won't be called back by a
cricket::Session at some point after Terminate() is to Destroy() it.

[Sergey Ulanov, 2011/07/07 00:50:30]

We cannot destroy it because cricket::SessionManager owns it. I added code in
CloseInternal() that disconnects cricket::Session::SignalState signal, but it's
not strictly necessary because destruction of sigslot::has_slots<> would do it
anyway.

   jingle_session_manager_->SessionDestroyed(this);
 }