Issue 7312005: WebSocket over SPDY: Move common test functions into separated file

Issue 7312005: WebSocket over SPDY: Move common test functions into separated file (Closed)

Created:
9 years, 5 months ago by Takashi Toyoshima

Modified:
9 years, 5 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refactoring on WebSocket over SPDY unit tests Move WebSocket over SPDY packet constructors into independent utility file. These constructors will be used in both of SpdyWebSocketStreamTest and WebSocketJobTest. BUG=NONE TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91678

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : spdy_websocket_stream_unittest #

Patch Set 4 : include spdy_framer's change #

Patch Set 5 : make util more generic #

Total comments: 2

Patch Set 6 : add const #

Patch Set 7 : rebase on lkgr #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -105 lines)			Patch
M	net/net.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_framer.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_websocket_stream_unittest.cc	View	1 2 3 4	2 chunks	+31 lines, -105 lines	0 comments	Download
A	net/spdy/spdy_websocket_test_util.h	View	1 2 3 4	1 chunk	+37 lines, -0 lines	0 comments	Download
A	net/spdy/spdy_websocket_test_util.cc	View	1 2 3 4 5	1 chunk	+93 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

If you have time to review it and are not in vacation :-), could you ...

9 years, 5 months ago (2011-07-07 04:58:24 UTC) #1

Takashi Toyoshima

I add spdy_framer.h to reduce changes which require net OWNERS review. I have a plan ...

9 years, 5 months ago (2011-07-07 05:20:46 UTC) #2

willchan no longer on Chromium

LGTM http://codereview.chromium.org/7312005/diff/3003/net/spdy/spdy_websocket_test_util.cc File net/spdy/spdy_websocket_test_util.cc (right): http://codereview.chromium.org/7312005/diff/3003/net/spdy/spdy_websocket_test_util.cc#newcode13 net/spdy/spdy_websocket_test_util.cc:13: static const char* kDefaultDataPointer = NULL; static const ...

9 years, 5 months ago (2011-07-07 08:03:34 UTC) #4

Takashi Toyoshima

9 years, 5 months ago (2011-07-07 08:12:22 UTC) #5

Thank you!!

http://codereview.chromium.org/7312005/diff/3003/net/spdy/spdy_websocket_test...
File net/spdy/spdy_websocket_test_util.cc (right):

http://codereview.chromium.org/7312005/diff/3003/net/spdy/spdy_websocket_test...
net/spdy/spdy_websocket_test_util.cc:13: static const char* kDefaultDataPointer
= NULL;
On 2011/07/07 08:03:35, willchan wrote:
> static const char * const

Done.

Expand Messages | Collapse Messages