Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 7312004: Remove policy template localizations from the Mac application bundle (Closed)

Created:
9 years, 5 months ago by gfeher
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove policy template localizations from the Mac application bundle Because they are taking up way too much space... BUG=88209 TEST=Size of Chromium app bundle drops by ~20M Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91697

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/app/policy/policy_templates.gypi View 1 chunk +6 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
gfeher
Undoing my previous stuff :/ Please review.
9 years, 5 months ago (2011-07-06 14:25:00 UTC) #1
tony
LGTM
9 years, 5 months ago (2011-07-06 17:43:01 UTC) #2
commit-bot: I haz the power
Try job failure for 7312004-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
9 years, 5 months ago (2011-07-07 12:11:14 UTC) #3
commit-bot: I haz the power
Change committed as 91697
9 years, 5 months ago (2011-07-07 13:10:40 UTC) #4
Nico
http://codereview.chromium.org/7312004/diff/1/chrome/app/policy/policy_templates.gypi File chrome/app/policy/policy_templates.gypi (right): http://codereview.chromium.org/7312004/diff/1/chrome/app/policy/policy_templates.gypi#newcode140 chrome/app/policy/policy_templates.gypi:140: # application bundle: 3.5MB, not 20 MB. (there was ...
9 years, 5 months ago (2011-07-12 22:25:23 UTC) #5
gfeher
9 years, 5 months ago (2011-07-12 22:27:35 UTC) #6
Argh.

http://codereview.chromium.org/7312004/diff/1/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.gypi (right):

http://codereview.chromium.org/7312004/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.gypi:140: # application bundle:
I'll fix this as a TBR.

Powered by Google App Engine
This is Rietveld 408576698