Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 7311001: Not posting appcache cleaning task if there is no appcache service. (Closed)

Created:
9 years, 5 months ago by marja(google)
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Not posting appcache cleaning task if there is no appcache service. An improvement idea from willchan; see http://codereview.chromium.org/7290025/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91689

Patch Set 1 #

Total comments: 7

Patch Set 2 : Code review; style fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/browser/browsing_data_remover.cc View 1 3 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
what about a unit test that the code works as intended? http://codereview.chromium.org/7311001/diff/1/chrome/browser/browsing_data_remover.cc File chrome/browser/browsing_data_remover.cc (right): ...
9 years, 5 months ago (2011-07-06 09:44:16 UTC) #1
marja(google)
http://codereview.chromium.org/7311001/diff/1/chrome/browser/browsing_data_remover.cc File chrome/browser/browsing_data_remover.cc (right): http://codereview.chromium.org/7311001/diff/1/chrome/browser/browsing_data_remover.cc#newcode227 chrome/browser/browsing_data_remover.cc:227: appcache_service_ = profile_->GetAppCacheService(); On 2011/07/06 09:44:16, jochen wrote: > ...
9 years, 5 months ago (2011-07-06 10:29:38 UTC) #2
jochen (gone - plz use gerrit)
LGTM http://codereview.chromium.org/7311001/diff/1/chrome/browser/browsing_data_remover.cc File chrome/browser/browsing_data_remover.cc (right): http://codereview.chromium.org/7311001/diff/1/chrome/browser/browsing_data_remover.cc#newcode227 chrome/browser/browsing_data_remover.cc:227: appcache_service_ = profile_->GetAppCacheService(); ok
9 years, 5 months ago (2011-07-06 10:39:45 UTC) #3
marja(google)
On 2011/07/06 09:44:16, jochen wrote: > what about a unit test that the code works ...
9 years, 5 months ago (2011-07-06 10:44:08 UTC) #4
michaeln
lgtm2!
9 years, 5 months ago (2011-07-06 19:31:49 UTC) #5
willchan no longer on Chromium
LGTM Sorry, didn't realize you wanted me to review it.
9 years, 5 months ago (2011-07-07 09:59:06 UTC) #6
marja(google)
On 2011/07/07 09:59:06, willchan wrote: > Sorry, didn't realize you wanted me to review it. ...
9 years, 5 months ago (2011-07-07 10:03:26 UTC) #7
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 10:52:49 UTC) #8
Change committed as 91689

Powered by Google App Engine
This is Rietveld 408576698