Pre-fill the 'Add Page' bookmark window with the current page (gtk and windows).

Pre-fill the 'Add Page' bookmark window with the current page (gtk and windows).

Selecting the 'Add Page' menu from the bookmark bar opens up the bookmark editor dialog with empty title and URL fields. Pre-fill these entries with the title and URL of the current page.

BUG=26052
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91873

[sky, 2011-07-07 16:02:50]

http://codereview.chromium.org/7310023/diff/1/chrome/browser/ui/gtk/bookmarks...
File chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc (right):

http://codereview.chromium.org/7310023/diff/1/chrome/browser/ui/gtk/bookmarks...
chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc:289: Browser* browser =
BrowserList::GetLastActiveWithProfile(profile_);
Move this off into bookmark_utils so you don't need to duplicate the logic.
Maybe GetURLAndTitleToBookmarkFromCurrentTab or something. And make use of
GetURLAndTitleToBookmark.

[sky, 2011-07-07 16:03:13]

Also, you're going to need Evan or Elliot to review gtk side.

  -Scott

[sadrul, 2011-07-07 16:37:38]

http://codereview.chromium.org/7310023/diff/1/chrome/browser/ui/gtk/bookmarks...
File chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc (right):

http://codereview.chromium.org/7310023/diff/1/chrome/browser/ui/gtk/bookmarks...
chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc:289: Browser* browser =
BrowserList::GetLastActiveWithProfile(profile_);
On 2011/07/07 16:02:50, sky wrote:
> Move this off into bookmark_utils so you don't need to duplicate the logic.
> Maybe GetURLAndTitleToBookmarkFromCurrentTab or something. And make use of
> GetURLAndTitleToBookmark.

Nice! I wasn't aware of bookmark_utils. Done. Thanks for the suggestion!

[sky, 2011-07-07 17:11:46]

LGTM

http://codereview.chromium.org/7310023/diff/4001/chrome/browser/bookmarks/boo...
File chrome/browser/bookmarks/bookmark_utils.h (right):

http://codereview.chromium.org/7310023/diff/4001/chrome/browser/bookmarks/boo...
chrome/browser/bookmarks/bookmark_utils.h:196: // Fills in the URL and title for
a bookmark from the current tab of the active
active -> specified

[sadrul, 2011-07-07 17:33:28]

http://codereview.chromium.org/7310023/diff/4001/chrome/browser/bookmarks/boo...
File chrome/browser/bookmarks/bookmark_utils.h (right):

http://codereview.chromium.org/7310023/diff/4001/chrome/browser/bookmarks/boo...
chrome/browser/bookmarks/bookmark_utils.h:196: // Fills in the URL and title for
a bookmark from the current tab of the active
On 2011/07/07 17:11:46, sky wrote:
> active -> specified

Done.

[Elliot Glaysher, 2011-07-08 17:41:01]

LGTM