Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7310022: Implement GetOrigins for indexeddb quota (Closed)

Created:
9 years, 5 months ago by dgrogan
Modified:
9 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Implement GetOrigins for indexeddb quota BUG=83652 TEST=llvm/Debug/unit_tests --gtest_filter=IndexedDBQuotaClientTest.* && llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser*:BrowsingDataIndexedDBHelperTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91796

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : don't filter extension origins #

Total comments: 2

Patch Set 4 : remove url_constants.h include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -3 lines) Patch
M content/browser/in_process_webkit/indexed_db_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_context.cc View 1 2 3 2 chunks +19 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client.cc View 1 chunk +9 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 1 4 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dgrogan
9 years, 5 months ago (2011-07-07 02:48:24 UTC) #1
hans
On 2011/07/07 02:48:24, dgrogan wrote: LGTM Try jobs?
9 years, 5 months ago (2011-07-07 09:37:13 UTC) #2
michaeln
http://codereview.chromium.org/7310022/diff/1001/content/browser/in_process_webkit/indexed_db_context.cc File content/browser/in_process_webkit/indexed_db_context.cc (right): http://codereview.chromium.org/7310022/diff/1001/content/browser/in_process_webkit/indexed_db_context.cc#newcode139 content/browser/in_process_webkit/indexed_db_context.cc:139: chrome::kExtensionScheme)) { I don't think extension origins should be ...
9 years, 5 months ago (2011-07-07 21:33:56 UTC) #3
dgrogan
http://codereview.chromium.org/7310022/diff/1001/content/browser/in_process_webkit/indexed_db_context.cc File content/browser/in_process_webkit/indexed_db_context.cc (right): http://codereview.chromium.org/7310022/diff/1001/content/browser/in_process_webkit/indexed_db_context.cc#newcode139 content/browser/in_process_webkit/indexed_db_context.cc:139: chrome::kExtensionScheme)) { On 2011/07/07 21:33:56, michaeln wrote: > I ...
9 years, 5 months ago (2011-07-07 21:55:37 UTC) #4
michaeln
LGTM
9 years, 5 months ago (2011-07-08 00:15:23 UTC) #5
michaeln
still lgtm, but... http://codereview.chromium.org/7310022/diff/6001/content/browser/in_process_webkit/indexed_db_context.cc File content/browser/in_process_webkit/indexed_db_context.cc (right): http://codereview.chromium.org/7310022/diff/6001/content/browser/in_process_webkit/indexed_db_context.cc#newcode15 content/browser/in_process_webkit/indexed_db_context.cc:15: #include "content/common/url_constants.h" is this include still ...
9 years, 5 months ago (2011-07-08 00:15:59 UTC) #6
dgrogan
http://codereview.chromium.org/7310022/diff/6001/content/browser/in_process_webkit/indexed_db_context.cc File content/browser/in_process_webkit/indexed_db_context.cc (right): http://codereview.chromium.org/7310022/diff/6001/content/browser/in_process_webkit/indexed_db_context.cc#newcode15 content/browser/in_process_webkit/indexed_db_context.cc:15: #include "content/common/url_constants.h" On 2011/07/08 00:15:59, michaeln wrote: > is ...
9 years, 5 months ago (2011-07-08 00:50:06 UTC) #7
commit-bot: I haz the power
9 years, 5 months ago (2011-07-08 01:32:56 UTC) #8 
Change committed as 91796

Powered by Google App Engine
This is Rietveld 408576698