Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 7310007: Trivial fixes to PPAPI (Closed)

Created:
9 years, 5 months ago by noelallen1
Modified:
9 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Trivial fixes to PPAPI Clean up incorrect guard end comment, and remove unused pp_var.h Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91749

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ppapi/c/ppb_core.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
noelallen1
9 years, 5 months ago (2011-07-06 17:42:03 UTC) #1
dmichael (off chromium)
LGTM when the trybots are happy. Please use my @chromium.org address in the future, and ...
9 years, 5 months ago (2011-07-06 17:57:10 UTC) #2
noelallen1
Thanks. http://codereview.chromium.org/7310007/diff/1/ppapi/c/ppb_core.h File ppapi/c/ppb_core.h (left): http://codereview.chromium.org/7310007/diff/1/ppapi/c/ppb_core.h#oldcode12 ppapi/c/ppb_core.h:12: #include "ppapi/c/pp_var.h" On 2011/07/06 17:57:10, dmichael1 wrote: > ...
9 years, 5 months ago (2011-07-06 22:16:45 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-07-06 22:51:48 UTC) #4
Try job failure for 7310007-1002 (retry) (previous was lost) on win for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698