Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 7310004: Add sample extension to allow/block third-party cookies. (Closed)

Created:
9 years, 5 months ago by Bernhard Bauer
Modified:
9 years, 5 months ago
Reviewers:
Mike West
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews
Visibility:
Public.

Description

Add sample extension to allow/block third-party cookies. This is basically a copy of the enableReferrer extension, but it manages a preference which is also exposed in chrome://settings/content, so the interaction with user-defined settings is visible. BUG=none TEST=sample extension works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92986

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -126 lines) Patch
chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/advicedog.jpg View Binary file 0 comments Download
A chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.html View 1 3 chunks +4 lines, -3 lines 0 comments Download
chrome/common/extensions/docs/examples/api/preferences/enableReferrer.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html View 1 1 chunk +2 lines, -1 line 0 comments Download
chrome/common/extensions/docs/examples/howto/contentscript_xhr.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.audits.html View 1 59 chunks +59 lines, -59 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.panels.html View 1 43 chunks +43 lines, -43 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.resources.html View 1 15 chunks +15 lines, -15 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 3 chunks +49 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 5 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bernhard Bauer
Please review.
9 years, 5 months ago (2011-07-06 12:10:27 UTC) #1
Bernhard Bauer
Ping? :-)
9 years, 5 months ago (2011-07-07 15:07:27 UTC) #2
Mike West
On 2011/07/07 15:07:27, Bernhard Bauer wrote: > Ping? :-) LGTM with tiny nits.
9 years, 5 months ago (2011-07-13 08:17:45 UTC) #3
Bernhard Bauer
On 2011/07/13 08:17:45, Mike West wrote: > On 2011/07/07 15:07:27, Bernhard Bauer wrote: > > ...
9 years, 5 months ago (2011-07-13 08:25:10 UTC) #4
Mike West
9 years, 5 months ago (2011-07-13 09:05:53 UTC) #5
*ahem*

http://codereview.chromium.org/7310004/diff/1/chrome/common/extensions/docs/e...
File
chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.html
(right):

http://codereview.chromium.org/7310004/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.html:89:
pref.set({'value':enabled, 'scope': scope});
Nit: Needs space between ":" and "enabled".

http://codereview.chromium.org/7310004/diff/1/chrome/common/extensions/docs/e...
File
chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html
(right):

http://codereview.chromium.org/7310004/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html:89:
pref.set({'value':enabled, 'scope': scope});
Nit: Needs a space between ":" and "enabled".

Powered by Google App Engine
This is Rietveld 408576698