Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 7309014: Correctly propagate toolchain setting in SConstruct. (Closed)

Created:
9 years, 5 months ago by piscisaureus
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Correctly propagate toolchain setting in SConstruct. Patch by Bert Belder. Committed: http://code.google.com/p/v8/source/detail?r=8555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M SConstruct View 1 chunk +1 line, -1 line 0 comments Download
M preparser/SConscript View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/SConscript View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/SConscript View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
piscisaureus
Building on windows with the `toolchain=gcc` option used to not work correctly if msvc was ...
9 years, 5 months ago (2011-07-05 20:38:19 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM
9 years, 5 months ago (2011-07-06 12:35:19 UTC) #2
Vyacheslav Egorov (Chromium)
9 years, 5 months ago (2011-07-06 12:42:49 UTC) #3
landed

Powered by Google App Engine
This is Rietveld 408576698