Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 7309013: Fix a few issues breaking cctest/test-lockers/Regress1433: (Closed)

Created:
9 years, 5 months ago by Vitaly Repeshko
Modified:
9 years, 5 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix a few issues breaking cctest/test-lockers/Regress1433: o The thread local state in an isolate has to be initialized before it's used. o v8::Locker was incorrectly tracking whether it's the topmost one. o Waking the profiler thread on shutdown should not leave the semaphore counter in an inconsitent state. R=fschneider@chromium.org BUG=v8:1522 TEST=cctest/test-lockers/Regress1433 Committed: http://code.google.com/p/v8/source/detail?r=8537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
M src/execution.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform-cygwin.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime-profiler.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +19 lines, -2 lines 0 comments Download
M src/v8threads.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 5 months ago (2011-07-05 14:58:50 UTC) #1
fschneider
9 years, 5 months ago (2011-07-05 15:11:42 UTC) #2
LGTM. 

Thanks for fixing this! Maybe mention the issue (1522 I believe) in the BUG=
line.

Powered by Google App Engine
This is Rietveld 408576698